[DependencyInjection] Remove deprecations across the component #50578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
di-deprecations
branch
from
864df90 to
284a935
Compare
src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/ContainerAwareTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
di-deprecations
branch
2 times, most recently
from
9a62ed7 to
0757d42
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
WitherAnnotationStaticReturnType, etc, there are still many fixtures that should be removed.
Using grep for "deprecated" in the component might help. Careful self-review also.
Thanks! 🙏
alexandre-daubois
force-pushed
the
di-deprecations
branch
from
0757d42 to
d835121
Compare
Member
|
(failures are related) |
Member
Author
|
I'll have a look at them, thank you for investigating Nicolas! |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 20, 2023
…ce`, `ContainerAwareTrait` and `ContainerAwareLoader` (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Deprecate `ContainerAwareInterface`, `ContainerAwareTrait` and `ContainerAwareLoader` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - As discussed in #50578 (comment) Commits ------- fc3c572 [DependencyInjection] Deprecate `ContainerAwareInterface`, `ContainerAwareTrait` and `ContainerAwareLoader`
alexandre-daubois
force-pushed
the
di-deprecations
branch
from
d835121 to
eadf0b7
Compare
src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
Outdated
Show resolved
Hide resolved
Member
Author
|
I'm currently having a look at the failing job https://github.com/symfony/symfony/actions/runs/5335835620/jobs/9669640171?pr=50578 |
alexandre-daubois
force-pushed
the
di-deprecations
branch
2 times, most recently
from
4a863f8 to
e3d816e
Compare
src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
di-deprecations
branch
2 times, most recently
from
32cb2fc to
0b9660f
Compare
nicolas-grekas
force-pushed
the
di-deprecations
branch
2 times, most recently
from
cd33c9b to
cb0e036
Compare
alexandre-daubois
force-pushed
the
di-deprecations
branch
4 times, most recently
from
6eda6bf to
60cdce8
Compare
alexandre-daubois
force-pushed
the
di-deprecations
branch
from
60cdce8 to
8730286
Compare
alexandre-daubois
force-pushed
the
di-deprecations
branch
from
8730286 to
cc4ef49
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2023
…(nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Do not use ContainerAwareInterface anymore | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to #50824, keeping this interface blocks compat of HK v6 with DI v7 for no good reasons. Let's drop ContainerAwareInterface from BundleInterface, it serves no purpose anyway. Unlocks #50578 Commits ------- 640c72a [HttpKernel] Do not use ContainerAwareInterface anymore
Member
|
Thank you @alexandre-daubois. |
Merged
This was referenced Jun 3, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2025
…handling (MatTheCat) This PR was merged into the 7.2 branch. Discussion ---------- [DependencyInjection] Fix `ServiceLocatorTagPass` indexes handling | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #60651 | License | MIT #50578 changed the `ServiceLocatorTagPass`’ behavior so that if the map is a list, its indexes always are replaced by the corresponding reference ID, even if they come from the `PriorityTaggedServiceTrait`. That means if your service map ends up as a list because e.g. your `default_index_method` returned contiguous integer, its indexes will be replaced. This PR reverts this change so that it works the same than v6. Commits ------- a73c9d1 [DependencyInjection] Fix `ServiceLocatorTagPass` indexes handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[MapDecorated], use#[AutowireDecorated]insteadProxyHelper, useSymfony\Component\VarExporter\ProxyHelperinsteadReferenceSetArgumentTrait@requiredannotation, use theSymfony\Contracts\Service\Attribute\Requiredattribute insteadnulltoContainerAwareTrait::setContainer()must be done explicitlyPhpDumperoptionsinline_factories_parameterandinline_class_loader_parameter, use optionsinline_factoriesandinline_class_loaderinsteadParameterBagcannot be numericsContainerAwareInterfaceandContainerAwareTrait, use dependency injection insteadContainerAwareLoader, use dependency injection in your fixtures instead