Skip to content

[Messenger] Prevent StopWorkerOnSignalsListener::$signals to be assigned to null in case SIGTERM constant doesn't exist #50532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Jun 2, 2023
Merged

[Messenger] Prevent StopWorkerOnSignalsListener::$signals to be assigned to null in case SIGTERM constant doesn't exist #50532

fabpot merged 1 commit into from
Jun 2, 2023

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jun 1, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50529
License MIT
Doc PR NA

Prevents the non-nullable property to be assigned to null 🙂

@alexandre-daubois
[Messenger] Prevent StopWorkerOnSignalsListener::$signals to be ass…
538a9ab 
…igned to null in case `SIGTERM` constant doesn't exist
@carsonbot carsonbot added this to the 6.4 milestone Jun 1, 2023
@carsonbot
Copy link

carsonbot commented Jun 1, 2023

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@alexandre-daubois alexandre-daubois changed the base branch from 6.4 to 6.3 June 1, 2023 15:10
@fabpot fabpot modified the milestones: 6.4, 6.3 Jun 2, 2023
@fabpot
Copy link
Member

fabpot commented Jun 2, 2023

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 26891af into symfony:6.3 Jun 2, 2023
@alexandre-daubois alexandre-daubois deleted the fix-null-signals branch June 2, 2023 13:08
@shyim
Copy link
Contributor

shyim commented Jun 12, 2023

Can we have a patch version for this fix? This seems to break our Symfony Project in dev-mode as EventDataCollector constructs the listener and then this bug is triggered.

#0 /Users/a.okko/Sites/6.5/testdev2/var/cache/dev_hb12f050958d24ad4316eb5bae74f455a/ContainerNjPmdUq/Shopware_Core_KernelDevDebugContainer.php(35680): Symfony\Component\Messenger\EventListener\StopWorkerOnSignalsListener->__construct() 
#1 /Users/a.okko/Sites/6.5/testdev2/var/cache/dev_hb12f050958d24ad4316eb5bae74f455a/ContainerNjPmdUq/Shopware_Core_KernelDevDebugContainer.php(13310): ContainerNjPmdUq\Shopware_Core_KernelDevDebugContainer::getMessenger_Listener_StopWorkerSignalsListenerService() 
#2 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/EventDispatcher.php(235): ContainerNjPmdUq\Shopware_Core_KernelDevDebugContainer::ContainerNjPmdUq\{closure}() 
#3 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/EventDispatcher.php(78): Symfony\Component\EventDispatcher\EventDispatcher->sortListeners() 
#4 /Users/a.okko/Sites/6.5/testdev2/src/Core/Content/Flow/Dispatching/FlowDispatcher.php(98): Symfony\Component\EventDispatcher\EventDispatcher->getListeners() 
#5 /Users/a.okko/Sites/6.5/testdev2/src/Core/Framework/Webhook/WebhookDispatcher.php(117): Shopware\Core\Content\Flow\Dispatching\FlowDispatcher->getListeners() 
#6 /Users/a.okko/Sites/6.5/testdev2/src/Core/Framework/Event/NestedEventDispatcher.php(64): Shopware\Core\Framework\Webhook\WebhookDispatcher->getListeners() 
#7 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(98): Shopware\Core\Framework\Event\NestedEventDispatcher->getListeners() 
#8 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(368): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getListeners() 
#9 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(177): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getListenersWithoutPriority() 
#10 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/DataCollector/EventDataCollector.php(75): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getNotCalledListeners() 
#11 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/Profiler/Profiler.php(100): Symfony\Component\HttpKernel\DataCollector\EventDataCollector->lateCollect() 
#12 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/EventListener/ProfilerListener.php(135): Symfony\Component\HttpKernel\Profiler\Profiler->saveProfile()

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jun 12, 2023

@shyim I guess this will come in 6.3.1, to be released by the end of the month

@tinect
Copy link
Contributor

tinect commented Jun 12, 2023

Is a more short-term release possible?

@fabpot fabpot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees

No one assigned

Labels

Bug Messenger Status: Reviewed

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

[Messenger] Null assigned to signals in StopWorkerOnSignalsListener

6 participants

@alexandre-daubois @carsonbot @fabpot @shyim @tinect @stof