Skip to content

[Filesystem] Fix broken symlink tests Windows PHP 7.4+ #50506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
May 31, 2023
Merged

[Filesystem] Fix broken symlink tests Windows PHP 7.4+ #50506

nicolas-grekas merged 1 commit into from
May 31, 2023

Conversation

@ausi
Copy link
Contributor

@ausi ausi commented May 31, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Followup to #50437
License MIT
Doc PR -

The test currently fail on windows with PHP >= 7.4

1) Symfony\Component\Filesystem\Tests\FilesystemTest::testReadBrokenLink
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'C:\…\Temp\1685536465.4767.1091468882/file'
+'C:\…\Temp\1685536465.4767.1091468882\file'

C:\…\src\Symfony\Component\Filesystem\Tests\FilesystemTest.php:1105

@carsonbot carsonbot added this to the 5.4 milestone May 31, 2023
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 31, 2023

Thank you @ausi.

@nicolas-grekas nicolas-grekas merged commit 221c9bb into symfony:5.4 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Filesystem Status: Needs Review

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@ausi @nicolas-grekas @carsonbot