[AssetMapper] Fix bug where dependencies were preloaded even if the parent was not #50356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 19, 2023
src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php
Outdated
Show resolved
Hide resolved
weaverryan
force-pushed
the
asset-mapper-fix-preload-dependencies
branch
from
be67a07 to
65dd360
Compare
nicolas-grekas
approved these changes
May 19, 2023
nicolas-grekas
force-pushed
the
asset-mapper-fix-preload-dependencies
branch
from
65dd360 to
feb680b
Compare
Member
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
importmap.php, if you havepreload => falsefor an assets... but that asset imports another assets, we would always list that imported asset as "preload => true". Basically, when looking at a dependency to determine if it should be preloaded, we need to first look at the parent to see if IT was preloaded.Cheers!