Skip to content

[Mime] Keep context after rendering emails #50233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rainrider wants to merge 1 commit into from
Closed

[Mime] Keep context after rendering emails #50233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Symfony/Bridge/Twig/Mime/TemplatedEmail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ public function markAsRendered(): void
{
$this->textTemplate = null;
$this->htmlTemplate = null;
$this->context = [];
}

/**
Expand Down
18 changes: 18 additions & 0 deletions src/Symfony/Bridge/Twig/Tests/Mime/BodyRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,24 @@ public function testRenderedOnceUnserializableContext()
$this->assertEquals('Text', $email->getTextBody());
}

public function testRendererKeepsContext()
{
$twig = new Environment(new ArrayLoader([
'text' => 'Text',
]));
$renderer = new BodyRenderer($twig);
$email = (new TemplatedEmail())
->to('fabien@symfony.com')
->from('helene@symfony.com')
;
$email->textTemplate('text');
$email->context(['test' => 'kept']);

$renderer->render($email);

$this->assertSame('kept', $email->getContext()['test']);
}

private function prepareEmail(?string $text, ?string $html, array $context = [], HtmlToTextConverterInterface $converter = null): TemplatedEmail
{
$twig = new Environment(new ArrayLoader([
Expand Down