Skip to content

[Cache] Fix DBAL deprecations and stop using NUL chars in tags prefix #49847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Mar 29, 2023
Merged

[Cache] Fix DBAL deprecations and stop using NUL chars in tags prefix #49847

fabpot merged 1 commit into from
Mar 29, 2023

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Mar 28, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The change of the tag prefix is motivated by #49713.

The other changes are to accommodate for deprecations in DBAL.

Note that DoctrineDbalAdapter::getServerVersion() keep calling the deprecated getWrappedConnection() method because although the code says one should exist, there is no alternative way to access the server version. Drivers are all missing a getServerVersion() method (/cc @derrabus FYI)

@carsonbot carsonbot added this to the 6.3 milestone Mar 28, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 28, 2023
Closed
@derrabus
Copy link
Member

derrabus commented Mar 28, 2023

DBAL 2 is still more popular than we'd like it to be, despite being officially EOL for almost a year now. My plan was to drop support in Symfony 7. I didn't want apps to be locked on a non-LTS release because they haven't upgraded to DBAL 3 yet (for whatever reason).

I won't block the change, it's just that I think we should've talked about that. 🙂

@stof
Copy link
Member

stof commented Mar 28, 2023

For Connection::PARAM_STR_ARRAY vs ArrayParameterType::STRING, we could do conditional usages of those constants, as we did in the past for the migration to ParameterType when we still wanted to support older versions of DBAL without it.
Or we could just ignore them for now (Connection::PARAM_STR_ARRAY will only be removed in DBAL 4.0, which is not a thing yet)

@nicolas-grekas nicolas-grekas changed the title [Cache] Require DBAL >= 3.6 and stop using NUL chars in tags prefix [Cache] Fix DBAL deprecations and stop using NUL chars in tags prefix Mar 28, 2023
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Mar 28, 2023

This makes the code a bit ugly but OK, updated.

@fabpot
Copy link
Member

fabpot commented Mar 29, 2023

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Mar 29, 2023
Closed
@fabpot fabpot merged commit 4fd8dcc into symfony:6.3 Mar 29, 2023
@nicolas-grekas nicolas-grekas deleted the cache-up branch March 31, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees

No one assigned

Labels

Cache Status: Reviewed

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @derrabus @stof @fabpot @carsonbot