[Console][DoctrineBridge] Remove backticks from exception messages #49829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Member
|
Please rebase for 6.3, this is not a bugfix ;) |
alexandre-daubois
force-pushed
the
remove-exception-backticks
branch
from
bf39c1f to
1c4b9e6
Compare
Member
Author
|
Oh you're right, that's rebased 🙂 |
alexandre-daubois
changed the title
OskarStark
approved these changes
Mar 27, 2023
carsonbot
changed the title
stof
approved these changes
Mar 27, 2023
chalasr
approved these changes
Mar 27, 2023
fabpot
approved these changes
Mar 27, 2023
Member
|
Thank you @alexandre-daubois. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 29, 2023
…n and error messages (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Standards] Improve code standards about exception and error messages After this one being merged symfony/symfony#49829, I think the coding standards about exception can be improved a bit 👍 Commits ------- 6d3fc80 [Standards] Improve code standards about exception and error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #49822 (comment), removes backticks of a few exception messages.