[Scheduler] Improve triggers performance when possible #49817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Mar 26, 2023
fabpot
commented
Mar 26, 2023
Contributor
|
Why do you think the original version was bad? The Now, there are two algos and "magic" with reflections... The goal of constructors is initialization of objects to a valid state. It's not a big deal, but having logic in a constructor except assertions of arguments is bad practice. Now it has too much "magic". The IMO it was better. |
upyx
reviewed
Mar 26, 2023
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
from
47b35b8 to
fe266a5
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
2 times, most recently
from
537e357 to
55933a2
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
5 times, most recently
from
6e48389 to
c494148
Compare
nicolas-grekas
approved these changes
May 21, 2023
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
from
c494148 to
f70a577
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
from
f70a577 to
c80e9ad
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
from
c80e9ad to
a53187f
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
2 times, most recently
from
1fe7222 to
ca3c30c
Compare
fabpot
force-pushed
the
scheduler-trigger-perf-improvments
branch
from
ca3c30c to
ebcced6
Compare
nicolas-grekas
approved these changes
May 22, 2023
kbond
approved these changes
May 22, 2023
Member
|
Thank you @fabpot. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
\DatePeriodfor the default trigger is great as it takes care of all date/time idiosyncrasies.But for high frequencies, that does not work well and performance becomes an issue. So, this PR solves this issue by always using the fast algorithm when the frequency is expressed in seconds (int) or an ISO period (like
PT2S) or when created from a string that uses a "simple" expression (like2 seconds)./cc @upyx