Skip to content

[Messenger] Fix TransportNamesStamp deserialization #49548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Mar 6, 2023
Merged

[Messenger] Fix TransportNamesStamp deserialization #49548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Symfony/Component/Messenger/Stamp/TransportNamesStamp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
final class TransportNamesStamp implements StampInterface
{
/**
* @param string[] $transports Transport names to be used for the message
* @param string[] $transportNames Transport names to be used for the message
*/
public function __construct(private array $transports)
public function __construct(private array $transportNames)
{
}

public function getTransportNames(): array
{
return $this->transports;
return $this->transportNames;
}
}
23 changes: 23 additions & 0 deletions src/Symfony/Component/Messenger/Tests/Stamp/TransportNamesStampTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@
namespace Symfony\Component\Messenger\Tests\Stamp;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Messenger\Envelope;
use Symfony\Component\Messenger\Stamp\TransportNamesStamp;
use Symfony\Component\Messenger\Transport\Serialization\Serializer;
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Normalizer\ArrayDenormalizer;
use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
use Symfony\Component\Serializer\Serializer as SymfonySerializer;

class TransportNamesStampTest extends TestCase
{
Expand All @@ -27,4 +33,21 @@ public function testGetSenders()
$this->assertSame($sender, $stampSenders[$key]);
}
}

public function testDeserialization()
{
$stamp = new TransportNamesStamp(['foo']);
$serializer = new Serializer(
new SymfonySerializer([
new ArrayDenormalizer(),
new ObjectNormalizer(),
], [new JsonEncoder()])
);

$deserializedEnvelope = $serializer->decode($serializer->encode(new Envelope(new \stdClass(), [$stamp])));

$deserializedStamp = $deserializedEnvelope->last(TransportNamesStamp::class);
$this->assertInstanceOf(TransportNamesStamp::class, $deserializedStamp);
$this->assertEquals($stamp, $deserializedStamp);
}
}