[HttpKernel] Collect data from every event dispatcher #49151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
from
2e832b7 to
e00675a
Compare
Member
|
We should not mix the listeners of various event dispatchers. That would make debugging much harder (as listeners from different dispatchers are totally separate lists). If we can profile multiple dispatchers, the webprofiler panel must display them separately (see how the mailer panel handles a project with multiple mailers configured for instance). |
Contributor
Author
|
@stof is that what you meant?
|
Member
|
Yeah, it should look like that (and it means you won't ever mix the listeners from multiple TraceableEventDispatcher together and so you won't re-sort anything in the collector) |
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
2 times, most recently
from
792075f to
6af1697
Compare
Contributor
Author
|
Indeed; PR updated thanks! |
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
7 times, most recently
from
aac6d83 to
9770a9c
Compare
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
3 times, most recently
from
8ccd9af to
7e014a1
Compare
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
from
7e014a1 to
a6f8a00
Compare
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
from
a6f8a00 to
b69b194
Compare
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
2 times, most recently
from
30b7e78 to
0dd6d17
Compare
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
2 times, most recently
from
e658f9f to
cfb35e8
Compare
Contributor
Author
|
No deprecation anymore 👌 |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Thanks, I like this path.
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
MatTheCat
force-pushed
the
profiler-event-dispatchers
branch
2 times, most recently
from
43164f5 to
6396377
Compare
nicolas-grekas
force-pushed
the
profiler-event-dispatchers
branch
from
6396377 to
a204629
Compare
nicolas-grekas
force-pushed
the
profiler-event-dispatchers
branch
from
a204629 to
7a77b3a
Compare
Member
|
Thank you @MatTheCat. |
Contributor
Author
|
Thank you for finishing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #49021: instead of only passing the main event dispatcher to the
EventDataCollector, we pass them all (thanks to theevent_dispatcher.dispatchertag).(The heading is now “Dispatched Events”.)
Check “Hide whitespace” when reviewing.