Skip to content

[FrameworkBundle][Workflow] Register alias for argument for workflow services with workflow name only #49102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jan 26, 2023
Merged

[FrameworkBundle][Workflow] Register alias for argument for workflow services with workflow name only #49102

nicolas-grekas merged 1 commit into from
Jan 26, 2023

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 25, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations?
Tickets
License MIT
Doc PR

This allows to write:

    public function __construct(
        #[Target('rules')]
        private readonly WorkflowInterface $rulesStateMachine,
    ) {

instead of:

    public function __construct(
        #[Target('rulesStateMachine')]
        private readonly WorkflowInterface $rulesStateMachine,
    ) {

@carsonbot carsonbot added this to the 6.3 milestone Jan 25, 2023
@carsonbot carsonbot changed the title [FrameworkBundle] Register alias for argument for workflow services with workflow name only [FrameworkBundle][Workflow] Register alias for argument for workflow services with workflow name only Jan 25, 2023
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 26, 2023

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 2ee39b3 into symfony:6.3 Jan 26, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 26, 2023
Closed
@lyrixx lyrixx deleted the workflow-target branch January 26, 2023 15:13
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees

No one assigned

Labels

Feature FrameworkBundle Status: Reviewed Workflow

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx @nicolas-grekas @stof @carsonbot