[DomCrawler] Add argument $normalizeWhitespace to Crawler::innerText() and make it return the first non-empty text
#48940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
Crawler::innerText()
OskarStark
requested review from
fabpot and
nicolas-grekas
and removed request for
nicolas-grekas
fabpot
changed the title
Crawler::innerText()Crawler::innerText()
fabpot
requested changes
Jan 10, 2023
Member
fabpot
left a comment
fabpot
left a comment
There was a problem hiding this comment.
You need to follow the instructions I've given in the other PR to avoid having a BC break.
carsonbot
changed the title
Crawler::innerText()Crawler::innerText()
Contributor
Author
Contributor
Author
|
@fabpot sorry I just ammended the commit: 9c08134 to have it exactly as you explained. But the fabbot.io action doesn't like the |
carsonbot
changed the title
Crawler::innerText()Crawler::innerText()
nicolas-grekas
changed the title
Crawler::innerText()$normalizeWhitespace to Crawler::innerText() and make it return the first non-empty text
…xt()` and make it return the first non-empty text
nicolas-grekas
approved these changes
Jan 11, 2023
fabpot
approved these changes
Jan 11, 2023
Member
|
Thank you @otsch. |
otsch
added a commit
to otsch/symfony-docs
that referenced
this pull request
Jan 12, 2023
According to the changes from symfony/symfony#48940
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 13, 2023
…` (otsch) This PR was merged into the 6.3 branch. Discussion ---------- [DomCrawler] Adapt docs for `Crawler::innerText()` According to the changes from symfony/symfony#48940 And as requested in symfony#17722 Commits ------- e5047ee Adapt docs for Crawler::innerText()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR instead of #48684 with target branch 6.3 as requested.