[Console] skip tests if the signal to be sent is not available #48329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 25, 2022
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
Member
Author
|
continues #48325 |
fabpot
approved these changes
Nov 25, 2022
Member
|
Thank you @xabbuh. |
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Dec 17, 2022
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Dec 17, 2022
fabpot
added a commit
that referenced
this pull request
Dec 17, 2022
…ing #48329) (HeahDude) This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix a test when pcntl is not available (following #48329) | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ The test is currently failing in AppVeyor (see https://ci.appveyor.com/project/fabpot/symfony/builds/45710392#L1577), the missing check seems present in tests above and below it. Don't know what happened. Commits ------- db5ed1f [Console] Fix a test when pcntl is not available (following #48329)
derrabus
added a commit
that referenced
this pull request
Dec 20, 2022
* 5.4: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help
derrabus
added a commit
that referenced
this pull request
Dec 20, 2022
* 6.0: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help
derrabus
added a commit
that referenced
this pull request
Dec 20, 2022
* 6.1: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help
derrabus
added a commit
that referenced
this pull request
Dec 20, 2022
* 6.2: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.