[Clock] Implement PSR-20 #48320
Merged
[Clock] Implement PSR-20 #48320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
clock
branch
from
7ac939a to
aa828cd
Compare
Contributor
|
You loose no time 🕐 hahaha |
stof
reviewed
Nov 25, 2022
nicolas-grekas
force-pushed
the
clock
branch
from
aa828cd to
a2f82c6
Compare
Member
|
Shouldn't we require |
Member
|
Is this for 6.2 or 6.3? The PR description says 6.2, but you're targeting the 6.3 branch. |
nicolas-grekas
force-pushed
the
clock
branch
from
a2f82c6 to
ff21357
Compare
Member
Author
|
Right, target + composer.json updated. |
Contributor
|
1.0 is tagged! 🎉 just restart the CI 😄 |
nicolas-grekas
force-pushed
the
clock
branch
from
ff21357 to
138dda9
Compare
chalasr
approved these changes
Nov 25, 2022
nicolas-grekas
force-pushed
the
clock
branch
from
138dda9 to
03fc7e1
Compare
Member
Author
|
Rebased, ready ! |
xabbuh
approved these changes
Nov 25, 2022
Member
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anticipating the creation of psr/clock v1.0
php-fig/fig-standards#1289
/cc @heiglandreas