[Mime] rename Part/BodyFile to Part/File #48060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeckers
approved these changes
Oct 31, 2022
Contributor
|
Please reorder the use statements as the fabbot mentioned |
Member
|
No markdown diff, did we forget to add some changelog entry? |
Member
Author
|
Updated! |
nicolas-grekas
force-pushed
the
mime-file
branch
from
1a5d40e to
5e2a2ef
Compare
chalasr
reviewed
Oct 31, 2022
fabpot
approved these changes
Nov 1, 2022
Member
|
Thank you @nicolas-grekas. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 28, 2023
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Mailer] Fix attachment changes The title of symfony/symfony#47711 did not change before merge, but actually only `attachPart` has been deprecated (renamed) in favor of `addPart`. I did not reintroduce the other methods as they may be deprecated in 7.1, so no need to document a way that may change in a few months. Also the `BodyFile` class has been renamed in symfony/symfony#48060 whereas the use in the example code was correct. Commits ------- 46923d0 [Mailer] Fix attachment changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was proposed during a chat within the core-team.
/cc @javiereguiluz