Shorten Placeholder for Search input #48001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Instead of this, could you please try to increase a bit the input size here: Thanks. |
Contributor
Author
|
yup, 215px works.
210px is still clipping
|
Member
|
@PhilETaylor if you can, please update this PR to keep the original text but apply the longer width. Thanks. |
Contributor
Author
|
yes sorry - School is out and kid had dentist, will do that now :) |
Contributor
Author
|
@javiereguiluz Done :) |
Contributor
Author
|
Failing tests are not my fault :) honest :-) |
PhilETaylor
changed the title
OskarStark
approved these changes
Oct 26, 2022
carsonbot
changed the title
fabpot
approved these changes
Oct 27, 2022
Member
|
Good catch, thanks @PhilETaylor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even on a stupidly large screen, the "Search on Symfony.com" input box has a placeholder that is truncated to
search on symfony.co(missing finalm)Symfony.cois not a valid or owned official domain.Screenshot is Safari, Google Chrome, Firefox. Firefox is the only one that renders the full placeholder.
Proposing to remove the word
onso that the placeholder is justsearch symfony.com