[HttpClient] Fix retrying requests when the content is used by the strategy #47990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 25, 2022
GrahamCampbell
approved these changes
Oct 25, 2022
maxbeckers
reviewed
Oct 25, 2022
maxbeckers
approved these changes
Oct 25, 2022
chalasr
approved these changes
Oct 25, 2022
jderusse
approved these changes
Oct 25, 2022
Member
|
Thank you @nicolas-grekas. |
This was referenced Oct 28, 2022
Merged
Merged
Merged
Merged
danielburger1337
added a commit
to SBSEDV/request-id-bundle
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already spotted in the linked issue, we just needed a reproducer. Here it is. The fix by @jderusse was correct.