[DoctrineBridge] Deprecate calling ContainerAwareEventManager::getListeners() without event name
#47864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
ContainerAwareEventManager::getListeners() without event nameContainerAwareEventManager::getListeners() without event name
stof
requested changes
Oct 14, 2022
derrabus
force-pushed
the
deprecate/get-listeners-without-event
branch
2 times, most recently
from
324702b to
8211fe6
Compare
Member
Author
|
Ready. |
xabbuh
approved these changes
Oct 15, 2022
fabpot
approved these changes
Oct 15, 2022
src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
deprecate/get-listeners-without-event
branch
from
8211fe6 to
af24827
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With EventManager 1.2, calling
EventManager::getListeners()without an event name has been deprecated. We should do the same for ourContainerAwareEventManager.