[Form] Made requirements for data mappers stricter #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption is thrown.
…y values. Removed duplication of code.
fabpot
added a commit
that referenced
this pull request
Jul 6, 2012
Commits ------- 5fe3f39 [Form] Made data mappers completely responsible for dealing with empty values. Removed duplication of code. 9bf6e8b [Form] Compound forms now always need a data mapper. Otherwise an exception is thrown. Discussion ---------- [Form] Made requirements for data mappers stricter Bug fix: no Feature addition: no Backwards compatibility break: (yes) Symfony2 tests pass: yes Fixes the following tickets: - Todo: - This cleanup was done while trying to fix #4715, which is not easily fixable right now. It breaks BC for those people who do not extend `FormType` and manually construct `Form` instances, which hopefully nobody does as it is absolutely *not* recommended at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: (yes)
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
This cleanup was done while trying to fix #4715, which is not easily fixable right now. It breaks BC for those people who do not extend
FormTypeand manually constructForminstances, which hopefully nobody does as it is absolutely not recommended at this time.