[Messenger] Allow password in redis dsn when using sockets #47475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ok @fabpot the AppVeyer failure is confusing me, its a totally different component ... all other tests pass... |
|
Hey! I think @nesk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
chalasr
approved these changes
Dec 18, 2022
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
This looks like a new feature to me, that should be for 6.3 I guess.
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Screwed up rebase. Will retry. |
Contributor
Author
|
[Messenger] Allow password in redis dsn when using sockets #48959 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 13, 2023
…kets (PhilETaylor) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Messenger] Allow password in redis dsn when using sockets | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #47393 `@Arakmar` | License | MIT | Doc PR | When a messenger async transport is configured with Redis (unix socket with a password), it gives DSN parsing errors. Using a Bunch of copy and pasted code blocks from the Redis cache adapter, this PR fixes the bug that doesn't parse a DSN such as `redis://password@/var/run/redis.sock` Replaces bad rebased #47475 Commits ------- 9af8ccf [Messenger] Allow password in redis dsn when using sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a messenger async transport is configured with Redis (unix socket with a password), it gives DSN parsing errors.
Using a Bunch of copy and pasted code blocks from the Redis cache adapter, this PR fixes the bug that doesn't parse a DSN such as
redis://password@/var/run/redis.sock