Add context option to configure the indentation of nested nodes for YamlEncoder
#47243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Aug 10, 2022
dbu
force-pushed
the
configure-yaml-indentation
branch
from
d261481 to
27b9dde
Compare
dbu
changed the title
dbu
force-pushed
the
configure-yaml-indentation
branch
2 times, most recently
from
5e5675c to
a5e7572
Compare
dbu
commented
Aug 10, 2022
Contributor
Author
|
@dunglas does this approach make sense? and would you have an idea what i got wrong with the service configuration? |
|
Hey! I think @mtarld has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
maxhelias
approved these changes
Sep 12, 2022
carsonbot
changed the title
nicolas-grekas
requested review from
OskarStark,
chalasr,
jderusse,
lyrixx,
wouterj,
xabbuh and
yceruto
as code owners
nicolas-grekas
force-pushed
the
configure-yaml-indentation
branch
from
a5e7572 to
d8cf930
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
configure-yaml-indentation
branch
from
d8cf930 to
ee371d1
Compare
Member
|
I've cherry-picked the changes on JsonEncoder in c693778, on top of #45554, branch 5.4 I've updated the patch attached to this PR to keep only the part related to YamlEncoder. I'll let you update the PR description if you don't mind, also add tests and a line in the changelog of the component? |
OskarStark
changed the title
YamlEncoder
dbu
force-pushed
the
configure-yaml-indentation
branch
2 times, most recently
from
ea26eba to
3257ef6
Compare
…d nodes for YamlEncoder
dbu
force-pushed
the
configure-yaml-indentation
branch
from
3257ef6 to
f1dfb8f
Compare
Contributor
Author
|
thanks. i rebased on 6.2 and updated the commit. i think the build errors are not related to my change but broken in the 6.2 branch. |
fabpot
approved these changes
Sep 29, 2022
carsonbot
changed the title
YamlEncoderYamlEncoder
Member
|
Thank you @dbu. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 3, 2022
…serializer (dbu) This PR was merged into the 6.2 branch. Discussion ---------- improve documentation of default_context for the serializer additional info for symfony#17310 fix symfony#17306 the code example will only work once symfony/symfony#47243 is merged Commits ------- 852aa11 document default context for the serializer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure the amount of spaces for indentation in Yaml Dumper.