[Console] Rename some arguments in ProgressBar #47205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Aug 5, 2022
fabpot
approved these changes
Aug 5, 2022
Member
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2022
…uiluz) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Console] Rename some arguments in ProgressBar | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - While documenting #46242, I thought something was odd: the code and docs talk about "resuming progress bars". But that's only a use-case of this feature. There are others: e.g. some task with optional steps; if you skip some step, you might want to show the progress at a certain starting point instead of `0`. So, this PR propose to rename some arguments. In any case, this is minor, so feel free to close if you think this is not relevant enough. Commits ------- c03e815 [Console] Rename some arguments in ProgressBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While documenting #46242, I thought something was odd: the code and docs talk about "resuming progress bars". But that's only a use-case of this feature. There are others: e.g. some task with optional steps; if you skip some step, you might want to show the progress at a certain starting point instead of
0.So, this PR propose to rename some arguments. In any case, this is minor, so feel free to close if you think this is not relevant enough.