[Notifier] Rename some arguments in notifier assertions #47204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Aug 5, 2022
OskarStark
approved these changes
Aug 6, 2022
Member
|
Thank you Javier. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 8, 2022
…viereguiluz) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Notifier][Testing] Document the notifier assertions Fixes #17057. Don't merge until a decision is made on symfony/symfony#47204 Commits ------- 497fb5d [Notifier][Testing] Document the notifier assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While documenting #46895, I thought about renaming some arguments. So here's a PR with that proposal for your consideration. Thanks.