[Mailer] Fix error message in case of an SMTP error #47162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Aug 2, 2022
fabpot
commented
| Q | A |
|---|---|
| Branch? | 6.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | n/a |
Contributor
|
Minor typo: it is written STMP instead of SMTP in the commit and title. |
xabbuh
reviewed
Aug 2, 2022
| } catch (TransportExceptionInterface) { | ||
| return parent::executeCommand(sprintf("HELO %s\r\n", $this->getLocalDomain()), [250]); | ||
| } | ||
| $response = $this->executeCommand(sprintf("EHLO %s\r\n", $this->getLocalDomain()), [250]); |
Member
There was a problem hiding this comment.
Why do we no longer need to catch transport exceptions anymore here?
Member
Author
There was a problem hiding this comment.
Here, we know that EHLO is supported, so there is no need to fall back to HELO.
fabpot
changed the title
fabpot
force-pushed
the
mailer-bette-error-message-61
branch
from
da8afdc to
6a88663
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.