[HttpKernel] Fix non-scalar check in surrogate fragment renderer #47073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aschempp
commented
Jul 27, 2022
aschempp
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #46152 |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Jul 27, 2022
Member
|
@aschempp Can you have a look at the tests, they seem to be broken by this change. |
carsonbot
changed the title
nicolas-grekas
force-pushed
the
bugfix/fragment-scalar-check
branch
from
65a2593 to
6b85cfd
Compare
Member
|
Thank you @aschempp. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.