[FrameworkBundle] Allow to specify null for exception mapping configuration values
#46956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-demb
force-pushed
the
allow-omit-exception-mapping-value
branch
from
e9a61ed to
5a52c79
Compare
fabpot
requested changes
Jul 16, 2022
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/exceptions.php
Show resolved
Hide resolved
andrew-demb
commented
Jul 18, 2022
src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
Outdated
Show resolved
Hide resolved
andrew-demb
force-pushed
the
allow-omit-exception-mapping-value
branch
from
ee0f479 to
26d12aa
Compare
Contributor
Author
|
Rebased on the latest |
carsonbot
changed the title
null for exception mapping configuration valuesnull for exception mapping configuration values
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
andrew-demb
force-pushed
the
allow-omit-exception-mapping-value
branch
from
26d12aa to
c1d5da3
Compare
andrew-demb
commented
Sep 30, 2022
| protected $exceptionsMapping; | ||
|
|
||
| /** | ||
| * @param array<class-string, array{log_level: string|null, status_code: int<100,599>|null}> $exceptionsMapping |
Contributor
Author
There was a problem hiding this comment.
Is it welcome to explicitly specify typing for mapping structure in Symfony codebase for now?
nicolas-grekas
approved these changes
Sep 30, 2022
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
All good on my side, thanks.
fabpot
approved these changes
Sep 30, 2022
fabpot
force-pushed
the
allow-omit-exception-mapping-value
branch
from
bcd9033 to
1de8f3a
Compare
Member
|
Thank you @andrew-demb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullshould be allowed because it is stated as allowed in the configuration info [1][2]Marked as bugfix due to an existing mismatch between config description and behavior.
[1]
symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Lines 1219 to 1220 in a2f27ad
[2]
symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Lines 1227 to 1228 in a2f27ad