[HtmlSanitizer] Allow null for sanitizer option allowed_link_hosts and allowed_media_hosts
#46849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
allowed_link_hosts and allowed_media_hosts
plfort
changed the title
allowed_link_hosts and allowed_media_hostsallowed_link_hosts and allowed_media_hosts
nicolas-grekas
approved these changes
Jul 28, 2022
carsonbot
changed the title
allowed_link_hosts and allowed_media_hostsallowed_link_hosts and allowed_media_hosts
…and `allowed_media_hosts`
nicolas-grekas
force-pushed
the
htmlsanitizer_allowurls_config
branch
from
3d2dd9e to
d3780c5
Compare
Member
|
Thank you @plfort. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set
allowed_link_hostsanallowed_media_hostsdefault value tonullinstead of an empty array, this introduces a breaking change.We can keep the current behavior by setting
defaultValue([])inConfiguration.phpbut I don't know how to set the default value to an empty array and set it tonullmanually in XML configuration.Need your help 😅