Skip to content

[Messenger] Ceil waiting time when multiplier is a float on retry #46797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jun 29, 2022
Merged

[Messenger] Ceil waiting time when multiplier is a float on retry #46797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Messenger/Retry/MultiplierRetryStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ public function getWaitingTime(Envelope $message): int
return $this->maxDelayMilliseconds;
}

return $delay;
return (int) ceil($delay);
}
}
7 changes: 6 additions & 1 deletion src/Symfony/Component/Messenger/Tests/Retry/MultiplierRetryStrategyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function testIsRetryableWithNoStamp()
/**
* @dataProvider getWaitTimeTests
*/
public function testGetWaitTime(int $delay, int $multiplier, int $maxDelay, int $previousRetries, int $expectedDelay)
public function testGetWaitTime(int $delay, float $multiplier, int $maxDelay, int $previousRetries, int $expectedDelay)
{
$strategy = new MultiplierRetryStrategy(10, $delay, $multiplier, $maxDelay);
$envelope = new Envelope(new \stdClass(), [new RedeliveryStamp($previousRetries)]);
Expand Down Expand Up @@ -83,5 +83,10 @@ public function getWaitTimeTests(): iterable
// never a delay
yield [0, 2, 10000, 0, 0];
yield [0, 2, 10000, 1, 0];

// Float delay
yield [1000, 1.5555, 5000, 0, 1000];
yield [1000, 1.5555, 5000, 1, 1555];
yield [1000, 1.5555, 5000, 2, 2419];
}
}