[Security] [LoginLink] Set custom lifetime for login link #46567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
mbrodala
force-pushed
the
login-link-custom-lifetime
branch
from
acb6293 to
a99fd44
Compare
Contributor
Author
|
No idea about the (unrelated?) test failures: https://github.com/symfony/symfony/runs/6722797430?check_suite_focus=true#step:8:4374 |
chalasr
reviewed
Jun 11, 2022
src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandlerInterface.php
Show resolved
Hide resolved
mbrodala
force-pushed
the
login-link-custom-lifetime
branch
2 times, most recently
from
3891de9 to
c28d322
Compare
fabpot
approved these changes
Jul 21, 2022
chalasr
reviewed
Jul 21, 2022
src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandlerInterface.php
Outdated
Show resolved
Hide resolved
…Interface.php Co-authored-by: Robin Chalas <chalasr@users.noreply.github.com>
fabpot
force-pushed
the
login-link-custom-lifetime
branch
from
df15098 to
2a153c8
Compare
Member
|
Thank you @mbrodala. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter
$lifetimetoLoginLinkHandlerInterface::createLoginLink()and its default implementationLoginLinkHandler. This allows setting an lifetime for each login link individually compared to the static and sharedlifetimeconfiguration option.