Skip to content

[Translation] Refresh local translations on PushCommand if the provider has domains #46239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalasr merged 1 commit into from
May 6, 2022
Merged

[Translation] Refresh local translations on PushCommand if the provider has domains #46239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Symfony/Component/Translation/Command/TranslationPushCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,16 +131,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$force = $input->getOption('force');
$deleteMissing = $input->getOption('delete-missing');

if (!$domains && $provider instanceof FilteringProvider) {
$domains = $provider->getDomains();
}

// Reading local translations must be done after retrieving the domains from the provider
// in order to manage only translations from configured domains
$localTranslations = $this->readLocalTranslations($locales, $domains, $this->transPaths);

if (!$domains) {
if ($provider instanceof FilteringProvider) {
$domains = $provider->getDomains();
}

if (!$domains) {
$domains = $this->getDomainsFromTranslatorBag($localTranslations);
}
$domains = $this->getDomainsFromTranslatorBag($localTranslations);
}

if (!$deleteMissing && $force) {
Expand Down