[Form] Add hash_property_path option to PasswordType
#46224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
5 times, most recently
from
2724b72 to
785c113
Compare
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
5 times, most recently
from
a8304ce to
a8c9dbb
Compare
|
Hey! I think @michaelKaefer has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
5 times, most recently
from
88e4fd2 to
1f7b15f
Compare
Member
yceruto
requested changes
Oct 14, 2022
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
This approach seems better than the previous one. Thanks for the second try!
...Symfony/Component/Form/Extension/PasswordHasher/Type/PasswordTypePasswordHasherExtension.php
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/PasswordHasher/Type/FormTypePasswordHasherExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
from
ef8b110 to
ffe9830
Compare
yceruto
reviewed
Oct 17, 2022
...Symfony/Component/Form/Extension/PasswordHasher/Type/PasswordTypePasswordHasherExtension.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Oct 17, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Oct 17, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Oct 17, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/PasswordHasherExtension.php
Outdated
Show resolved
Hide resolved
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
from
5afae70 to
533142b
Compare
yceruto
reviewed
Oct 18, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Show resolved
Hide resolved
nicolas-grekas
added
the
❄️ Feature Freeze
yceruto
previously approved these changes
Oct 20, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
Member
|
Some tests failures seem to be related https://github.com/symfony/symfony/actions/runs/3274200868/jobs/5387417225#step:7:2208 can you check? |
Contributor
Author
|
Fixed in e765a9b All green now 🚀 |
yceruto
approved these changes
Oct 20, 2022
chalasr
approved these changes
Oct 20, 2022
src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
Outdated
Show resolved
Hide resolved
...mponent/Form/Tests/Extension/PasswordHasher/Type/PasswordTypePasswordHasherExtensionTest.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
password-hash-mapping-extension
branch
from
88f6c8b to
9c06ab2
Compare
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
from
9c06ab2 to
56c1282
Compare
Seb33300
force-pushed
the
password-hash-mapping-extension
branch
from
56c1282 to
7065dfe
Compare
Contributor
Author
|
@chalasr I force pushed to change |
fabpot
approved these changes
Oct 22, 2022
Member
|
Thank you @Seb33300. |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 23, 2022
…300) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Form] Document the `hash_property_path` option Documentation for symfony/symfony#46224 Commits ------- 228d73e [Form] Document the `hash_property_path` option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #42883 but using a Form Extension and rebased to 6.1 & tests.
This PR adds a new
hash_mappingoption toPasswordType.The
hash_mappingoption can be set with a property path where we want to set the hashed password.The
hash_mappingoption can only be used on unmapped fields to minimize plain password leak.