Skip to content

[HttpKernel] Handle previously converted DateTime arguments #46199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
May 1, 2022
Merged

[HttpKernel] Handle previously converted DateTime arguments #46199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/DateTimeValueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
{
$value = $request->attributes->get($argument->getName());

if ($value instanceof \DateTimeInterface) {
yield $value;

return;
}

if ($argument->isNullable() && !$value) {
yield null;

Expand Down
15 changes: 15 additions & 0 deletions ...fony/Component/HttpKernel/Tests/Controller/ArgumentResolver/DateTimeValueResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,21 @@ public function testNullableWithEmptyAttribute()
$this->assertNull($results[0]);
}

public function testPreviouslyConvertedAttribute()
{
$resolver = new DateTimeValueResolver();

$argument = new ArgumentMetadata('dummy', \DateTime::class, false, false, null, true);
$request = self::requestWithAttributes(['dummy' => $datetime = new \DateTime()]);

/** @var \Generator $results */
$results = $resolver->resolve($request, $argument);
$results = iterator_to_array($results);

$this->assertCount(1, $results);
$this->assertSame($datetime, $results[0]);
}

public function testCustomClass()
{
date_default_timezone_set('UTC');
Expand Down