Skip to content

Conversation

@l-vo
Copy link
Contributor

@l-vo l-vo commented Apr 16, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

To merge #45491 in 5.4, the code has been changed to be 7.2 compliant. This PR restores the original code for Symfony versions that support php >= 8.0 (see #45491 (comment)).

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but for 6.1

@carsonbot carsonbot changed the title Restore PHP8 features for Doctrine debug middlewares [DoctrineBridge] Restore PHP8 features for Doctrine debug middlewares Apr 19, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.0, 6.1 Apr 19, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.0 to 6.1 April 19, 2022 08:35
@nicolas-grekas
Copy link
Member

Thank you @l-vo.

@nicolas-grekas nicolas-grekas force-pushed the add_middleware_datacollector_sf6 branch from f0ff902 to f4bdd82 Compare April 19, 2022 08:35
@nicolas-grekas nicolas-grekas merged commit 9391281 into symfony:6.1 Apr 19, 2022
@l-vo l-vo deleted the add_middleware_datacollector_sf6 branch April 19, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants