Skip to content

Conversation

@jderusse
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

Fix wrong value injected in lock factory. See #44155 (comment)

@carsonbot carsonbot changed the title Fix env resolution in lock configuration [FrameworkBundle] Fix env resolution in lock configuration Apr 12, 2022
@carsonbot carsonbot added this to the 4.4 milestone Apr 12, 2022
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 63de80b into symfony:4.4 Apr 12, 2022
@stof
Copy link
Member

stof commented Apr 12, 2022

sharing the services based on the fact that they share the same resolved DSN at build time could also create such bugs. Instead, the $storeDefinitionId should probably check that they rely on the same env placeholders to be sure that the runtime resolution will still be the same (or not share services at all)

@jderusse jderusse deleted the fix-lock branch April 12, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants