Skip to content

[PhpUnitBridge] Fix ignoreFile comments #45921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Apr 3, 2022
Merged

[PhpUnitBridge] Fix ignoreFile comments #45921

nicolas-grekas merged 1 commit into from
Apr 3, 2022
+4 −1

Conversation

@mondrake
Copy link
Contributor

@mondrake mondrake commented Apr 2, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45918
License MIT

@carsonbot carsonbot added this to the 6.1 milestone Apr 2, 2022
@carsonbot carsonbot changed the title [PHPUnitBridge] Fix ignoreFile comments [PhpUnitBridge] Fix ignoreFile comments Apr 2, 2022
@mondrake mondrake marked this pull request as draft April 2, 2022 18:09
@mondrake mondrake marked this pull request as ready for review April 2, 2022 21:10
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 3, 2022

Thank you @mondrake.

@nicolas-grekas nicolas-grekas merged commit f97db87 into symfony:6.1 Apr 3, 2022
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 3, 2022
Closed
@mondrake mondrake deleted the dev-comments branch April 3, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees

No one assigned

Labels

Bug PhpUnitBridge Status: Needs Review

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

[PHPUnitBridge] ignoreFile does not allow comments

3 participants

@mondrake @nicolas-grekas @carsonbot