[Form] Add prototype_options to CollectionType #45605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @HeahDude has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Contributor
Author
|
Hello @xabbuh, do you think there is any chance that this gets merged? I would like to close it if there is no chance. Thanks for any answer. |
Member
|
@michaelKaefer This sounds reasonable to me. |
Contributor
Author
|
@xabbuh Do you mean the PR sounds reasonable or closing the PR sounds reasonable? |
yceruto
reviewed
Mar 27, 2022
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
Looks good to me, after a minor comment
michaelKaefer
added a commit
to michaelKaefer/symfony-docs
that referenced
this pull request
Mar 28, 2022
Contributor
Author
|
@xabbuh @yceruto Thank you, I added the allowed type definition and created a PR for the docs: symfony/symfony-docs#16664. |
Member
|
Can you please add a test case, and also a line in the changelog of the component? |
Contributor
Author
|
@nicolas-grekas Sorry, I forgot that, I added both now. |
xabbuh
approved these changes
Apr 3, 2022
nicolas-grekas
approved these changes
Apr 3, 2022
Member
|
Thank you @michaelKaefer. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 4, 2022
This PR was submitted for the 6.0 branch but it was merged into the 6.1 branch instead. Discussion ---------- [Form] Add new prototype_options Related PR: symfony/symfony#45605 Commits ------- ec76b6a [Form] Add new prototype_options
Merged
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Jun 4, 2022
This PR was merged into the 4.x branch. Discussion ---------- Use CRUD form in CollectionField Implements what `@furang` wrote here: #4766. Needs Symfony 6.1 because it uses `prototype_options` (See symfony/symfony#45605). I createad a reproducer here: https://github.com/michaelKaefer/ea-reproducer/tree/issue/4766-create-update-relations. Without this PR you have to create a form type and set it as entry type for associated entities when using `CollectionField`. This doesn't allow using EA fields and could sometimes kind of duplicates the CRUD form of the associated entity. This new option would enable you to use the CRUD form (if you need different form fields and you cannot reuse the CRUD form you still can implement a custom form type). Related to #3304. Commits ------- 24a99a1 Use CRUD form in CollectionField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows defining options for the form for new entries (the prototype form) which differ from the options for the form for existing entries.
My use case: I need this when using EasyAdminBundle. In the form for an entity
PersonI have aCollectionTypefor a related entityBooks. There I can edit theBooksthat aPersonalready has and add newBooks. The change would allow me to show (or disable, etc.) a form field in theBookform only when an existingBookis edited (and not show it when a newBookis added).As far as I can tell it is not a BC break to add this new option. I can provide another PR for the docs if this should get merged.