[FrameworkBundle] Fix resetting container between tests #45595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2022
nicolas-grekas
force-pushed
the
fwb-reset-test-container
branch
from
87c4591 to
4453bdb
Compare
This was referenced Mar 5, 2022
Merged
Merged
Merged
kbond
added a commit
to kbond/foundry
that referenced
this pull request
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #45479 and #45581, related to #34078.
Calling
boot()on an already booted kernel does reset the container, so we don't need to care anymore about the state of kernel.#45580 is fixed by removing
private static $kernelContainer, which can be out of sync withstatic::$kernel->getContainer()sinceKernelBrowsercreates new containers when shutting down the kernel between requests.