Skip to content

[Console] Revert StringInput bc break from #45088 #45590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Mar 1, 2022
Merged

[Console] Revert StringInput bc break from #45088 #45590

fabpot merged 1 commit into from
Mar 1, 2022

Conversation

@fabpot
Copy link
Member

@fabpot fabpot commented Mar 1, 2022

Q A
Branch? 5.3
Bug fix? yes (BC break)
New feature? no
Deprecations? no
Tickets Refs #45088
License MIT
Doc PR n/a

@fabpot fabpot requested a review from chalasr as a code owner March 1, 2022 08:25
@carsonbot
Copy link

carsonbot commented Mar 1, 2022

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1.

Cheers!

Carsonbot

@fabpot
Copy link
Member Author

fabpot commented Mar 1, 2022

Thank you @bobthecow.

@fabpot fabpot merged commit 84f0d0e into symfony:5.3 Mar 1, 2022
@fabpot fabpot deleted the bc-break-hot-fix branch March 1, 2022 08:25
@fabpot fabpot mentioned this pull request Mar 1, 2022
Merged
@bobthecow
Copy link
Contributor

bobthecow commented Mar 1, 2022

Thank you!

This was referenced Mar 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees

No one assigned

Labels

Bug Console Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabpot @carsonbot @bobthecow