[Serializer] Fixed framework.serializer.default_context is not working for JsonEncoder #45554
Conversation
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Ad this is a new feature, this should target the 5.c branch. Also, maybe should we allow providing different contexts for encoding and decoding.
| protected $decodingImpl; | ||
|
|
||
| public function __construct(JsonEncode $encodingImpl = null, JsonDecode $decodingImpl = null) | ||
| public function __construct(array $defaultContext = [], JsonEncode $encodingImpl = null, JsonDecode $decodingImpl = null) |
There was a problem hiding this comment.
This is a BC break, could you move this parameter at the end of the list please?
There was a problem hiding this comment.
I understand, but I'm not sure how to set different defaultContext for encoding and decoding, because JsonEncode and JsonDecode are not passed into JsonEncoder as a service, and other places are the same defaultContext set in framework.serializer.default_context, Like XmlEncoder or DateTimeNormalizer.
also I have tried providing the defaultContext parameter at the end, but this raises an error in DefinitionErrorExceptionPass:
Invalid constructor argument 3 for service "serializer.encoder.json": argument 1 must be defined before. Check your service definition.
Do you have any idea?
There was a problem hiding this comment.
Actually, the proper solution is maybe to register them as services indeed!
|
@siganushka Are you still interested in moving this PR forward? |
…g for JsonEncoder
|
Thank you @siganushka. |
5 participants
Fixed
framework.serializer.default_contextis not working forJsonEncoderlike
XmlEncoderorDateTimeNormalizer, thearray $defaultContextargument bindings fromSerializerPass, but not working forJsonEncoder, I addedarray $defaultContextargument and passed toJsonEncodeandJsonDecode.https://github.com/symfony/serializer/blob/5.4/DependencyInjection/SerializerPass.php#L69-L75