Make constraint violation interfaces stringable #45484
Conversation
HypeMC
changed the title
|
Hey! I think @jschaedl has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
What's the use case that made you open this? |
The use case is casting the errors to a string for dev messages, which should be legit according to the docs, but then static analysis tools complain, which makes sense since there's no guarantee that the implementation being use is stringable. Adding it to the interface would assure that changing the implantation wont break any code and will satisfy static analysis tools. |
HypeMC
force-pushed
the
stringable-constraint-violations
branch
from
5416369 to
9c9408f
Compare
|
im not sure docs should rely on a debugging-string, but rather should show a serialized constraint violation list or some manually constructed payload |
HypeMC
force-pushed
the
stringable-constraint-violations
branch
from
9c9408f to
91bf1b1
Compare
HypeMC
force-pushed
the
stringable-constraint-violations
branch
from
91bf1b1 to
4cead0c
Compare
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
About UPGRADE-7.0.md, it's already outdated. We need to clarify how we deal with this file at the policy level. Shouldn't be a blocker for this PR IMHO.
carsonbot
changed the title
|
Thank you @HypeMC. |
6 participants
Currently the
ConstraintViolationInterface&ConstraintViolationListInterfacedon't have a__toString()method even though their only implementations do. Since thevalidatemethod returns aConstraintViolationListInterfacetrying to cast the errors into a string doesn't sit well with static analysis tools.Here I've used an example from the docs:
This PR adds a
__toString()method to the interfaces via an@methodtag. In Symfony 7 theStringableinterface can be implemented instead.