[HttpKernel] Reset services between requests performed by KernelBrowser #45479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hk-browser-reset
branch
from
f7a6b53 to
592a00a
Compare
yceruto
approved these changes
Feb 19, 2022
fabpot
approved these changes
Feb 19, 2022
Member
|
Thank you @nicolas-grekas. |
This was referenced Feb 28, 2022
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Mar 1, 2022
…icolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fix resetting container between tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40965, fix #45580 | License | MIT | Doc PR | - Replaces #45479 and #45581, related to #34078. Calling `boot()` on an already booted kernel does reset the container, so we don't need to care anymore about the state of kernel. #45580 is fixed by removing `private static $kernelContainer`, which can be out of sync with `static::$kernel->getContainer()` since `KernelBrowser` creates new containers when shutting down the kernel between requests. Commits ------- 4453bdb [FrameworkBundle] Fix resetting container between tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes memory leaks caused by the container not being reset between requests made via
KernelBrowserwhen not callingKernelBrowser::disableReboot();.There is already a call to
$container->reset()inKernelTestCase::ensureKernelShutdown(), butKernelBrowsercreates new container instances for each requests, and those containers were never reset.