Leverage the match expression #45433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
requested review from
OskarStark,
chalasr,
dunglas,
jderusse,
xabbuh and
yceruto
as code owners
fancyweb
force-pushed
the
minor/leverage-match
branch
from
1a50e49 to
67b5237
Compare
fancyweb
commented
Feb 15, 2022
derrabus
reviewed
Feb 15, 2022
src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Dumper/XmlReferenceDumper.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
Outdated
Show resolved
Hide resolved
GromNaN
reviewed
Feb 16, 2022
Contributor
Author
|
I'm totally in favor of switching to FQCN but it needs to be done globally in another PR I guess. That's unrelated to the match expression for me. |
Member
|
We prefer changing lines once in a single PR, because that helps when running git blame later on. |
fancyweb
force-pushed
the
minor/leverage-match
branch
from
67b5237 to
b1be99b
Compare
fancyweb
commented
Feb 17, 2022
fancyweb
force-pushed
the
minor/leverage-match
branch
from
b1be99b to
7d241b1
Compare
Member
|
Looks like PHP CS Fixer does not like the code style proposed by @nicolas-grekas (yet). |
derrabus
reviewed
Feb 18, 2022
Member
I'm fine adopting php-cs-fixer suggestion then (after removing the trailing coma) |
jderusse
reviewed
Feb 18, 2022
src/Symfony/Component/DependencyInjection/Loader/IniFileLoader.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
minor/leverage-match
branch
2 times, most recently
from
3a866fe to
b1284dc
Compare
fancyweb
force-pushed
the
minor/leverage-match
branch
from
b1284dc to
217dc16
Compare
nicolas-grekas
approved these changes
Feb 18, 2022
fabpot
approved these changes
Feb 19, 2022
Member
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Sep 23, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Convert switch cases to match expression | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Continuation of #45433 using [rector rule ](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changeswitchtomatchrector) `@fancyweb` friendly ping as you've worked on it previously. Commits ------- f3ec7ac Convert switch cases to match expression
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Sep 23, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Convert switch cases to match expression | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Continuation of symfony/symfony#45433 using [rector rule ](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changeswitchtomatchrector) `@fancyweb` friendly ping as you've worked on it previously. Commits ------- f3ec7ac324 Convert switch cases to match expression
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Sep 23, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Convert switch cases to match expression | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Continuation of symfony/symfony#45433 using [rector rule ](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changeswitchtomatchrector) `@fancyweb` friendly ping as you've worked on it previously. Commits ------- f3ec7ac324 Convert switch cases to match expression
symfony-splitter
pushed a commit
to symfony/config
that referenced
this pull request
Sep 23, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Convert switch cases to match expression | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Continuation of symfony/symfony#45433 using [rector rule ](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changeswitchtomatchrector) `@fancyweb` friendly ping as you've worked on it previously. Commits ------- f3ec7ac324 Convert switch cases to match expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative to leverage the
matchexpression when we can in order to keep on modernizing the code (afterarray_is_list(),str_starts_with(),str_ends_with()andstr_contains()).Firstly, let's see if the CI is green.