[ErrorHandler] trigger deprecations for @final properties
#45360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
cf4b347 to
5d0282f
Compare
derrabus
approved these changes
Feb 8, 2022
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Looks good. Maybe we should document a way forward.
yceruto
approved these changes
Feb 8, 2022
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
5d0282f to
92b917e
Compare
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
92b917e to
3ec3d6b
Compare
fancyweb
approved these changes
Feb 9, 2022
Contributor
fancyweb
left a comment
fancyweb
left a comment
There was a problem hiding this comment.
I'm approving the code but some tests are missing for me:
- test with two classes in the same namespace
- test with a class outside the
Symfony\namespace - test that the behavior is different for a static property
- test that the behavior is different when the property is typed
I can help you if you want.
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
3ec3d6b to
d535ced
Compare
Member
Author
PR welcome on my fork :)
I removed that check |
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
d535ced to
0c4a7c7
Compare
Member
Author
|
This PR will be green after #45371 is merged. Review welcome. |
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
0c4a7c7 to
061943a
Compare
carsonbot
changed the title
@final properties@final properties
carsonbot
changed the title
@final properties@final properties
nicolas-grekas
force-pushed
the
eh-final-props
branch
from
c00cd1b to
eada4c0
Compare
Member
Author
|
Thank you @fancyweb. |
Merged
This was referenced Jul 21, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Jul 28, 2023
…grekas) This PR was merged into the 7.0 branch. Discussion ---------- Add types to public and protected properties | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - :hot_face: Allowed by #45360 Follows #51068 and #51067 Commits ------- 7ea2461 Add types to public and protected properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes DebugClassLoader trigger a deprecation when a property in a child class is redefined while the same property is
@finalon the parent class (the deprecation is silenced when both classes live in the exact same namespace or when the child property is deprecated.)It also makes all properties in the
Symfony\namespace implicitly@final, unless they are typed. The goal here is to be able to add types to all properties in 7.0, thus fixing #43600.