[Serializer] Fix ignored callbacks in denormalization #45323
Merged
+299
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @Th3Mouk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/Features/CallbacksTestTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/Features/CallbacksTestTrait.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Feb 11, 2022
Member
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
I'm in favor of deprecating the callbacks and recommending using custom normalizers instead and I would revert the changes made to the PHPDoc for consistency, otherwise +1.
Member
|
Thank you @benjaminmal. |
Member
|
I just found that this is already deprecated and removed from 5.4. |
Member
|
Hum, only |
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop ignoring callbacks in denormalization. #freeTheCallbacks!!!