Skip to content

[Routing] Enrich MissingMandatoryParametersException #45075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jan 20, 2022
Merged

[Routing] Enrich MissingMandatoryParametersException #45075

nicolas-grekas merged 1 commit into from
Jan 20, 2022

Conversation

@adrienlucas
Copy link
Contributor

@adrienlucas adrienlucas commented Jan 19, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets NA
License MIT
Doc PR NA

This allows to more easily recover after a failing call to UrlGenerator::generate.

@carsonbot carsonbot added this to the 6.1 milestone Jan 19, 2022
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from 2f754c1 to c3b7ed3 Compare January 19, 2022 09:49
chalasr
chalasr requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell a bit more about the use case?

@adrienlucas
Copy link
Contributor Author

adrienlucas commented Jan 19, 2022

Can you tell a bit more about the use case?

I'm using the UrlGenerator::generate to iterate over all the routes and "smoke test" an app. Without this getters, I can still compute the missing parameters but it is less convenient.

@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from c3b7ed3 to b7ef7d1 Compare January 19, 2022 10:57
@chalasr
Copy link
Member

chalasr commented Jan 19, 2022

Thanks, looks sensible to me. Can you fix fabbot's report?

@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch 2 times, most recently from 22092a1 to 166aa54 Compare January 19, 2022 11:14
@adrienlucas
Copy link
Contributor Author

adrienlucas commented Jan 19, 2022

Thanks, looks sensible to me. Can you fix fabbot's report?

Fixed ! Thank you !

@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from 166aa54 to b6ae69a Compare January 19, 2022 12:53
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from b6ae69a to f641c07 Compare January 20, 2022 08:33
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch 2 times, most recently from d0c940d to 6889a7a Compare January 20, 2022 09:30
nicolas-grekas
nicolas-grekas reviewed Jan 20, 2022
View reviewed changes
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from 6889a7a to f562935 Compare January 20, 2022 13:50
nicolas-grekas
nicolas-grekas approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick and good to me

@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch from f562935 to 88fb3c9 Compare January 20, 2022 13:57
nicolas-grekas
nicolas-grekas reviewed Jan 20, 2022
View reviewed changes
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch 2 times, most recently from cb5bc33 to 666069b Compare January 20, 2022 14:11
stof
stof requested changes Jan 20, 2022
View reviewed changes
@adrienlucas adrienlucas force-pushed the enrich-router-missing-parameters-exception branch 4 times, most recently from f60704c to cefa8b2 Compare January 20, 2022 14:22
@nicolas-grekas nicolas-grekas force-pushed the enrich-router-missing-parameters-exception branch from cefa8b2 to 35f61aa Compare January 20, 2022 14:29
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 20, 2022

Thank you @adrienlucas.

@nicolas-grekas nicolas-grekas merged commit 5c37c1f into symfony:6.1 Jan 20, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@HypeMC HypeMC HypeMC left review comments

@stof stof stof requested changes

@chalasr chalasr chalasr approved these changes

+1 more reviewer

@plozmun plozmun plozmun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Routing

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

7 participants

@adrienlucas @chalasr @nicolas-grekas @stof @plozmun @HypeMC @carsonbot