[HttpClient] Remove deprecated usage of GuzzleHttp\Promise\queue
#44890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
GuzzleHttp\Promise\queueGuzzleHttp\Promise\queue
Member
|
Thank you! This should be fixed on the 4.4 branch, I suppose. Also, please make fabbot happy. 🙂 |
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
wouterj,
xabbuh and
yceruto
as code owners
Member
|
Thank you @GrahamCampbell. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 13, 2022
…\promise_for (plozmun) This PR was merged into the 5.3 branch. Discussion ---------- [HttpClient] Remove deprecated usage of GuzzleHttp\Promise\promise_for | Q | A | ------------- | --- | Branch? | 5.3, | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to #44890 but this function was introduced in 5.1 #37927 Commits ------- 3d2ed70 [HttpClient] Remove deprecated usage of GuzzleHttp\Promise\promise_for
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuzzleHttp\Promise\queuewas deprecated in1.4.0in favour ofGuzzleHttp\Promise\Utils::queue, to enable PSR-4 compliance and eliminate issues with multiple installs globally and locally. Since the minimum version of this package in Symfony's composer.json is1.4.0(^1.4), then this change should be safe to make.cc @Nyholm