[Serializer] Make document type nodes ignorable #44650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenner
force-pushed
the
serializer-xmlencoder-ignore-document-type
branch
2 times, most recently
from
86c2978 to
410f9ba
Compare
|
Hey! I think @mvorisek has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Any news on this? |
nicolas-grekas
approved these changes
Feb 13, 2022
boenner
force-pushed
the
serializer-xmlencoder-ignore-document-type
branch
from
410f9ba to
2c75e27
Compare
Member
|
Thank you @boenner. |
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #44363: while looping over all nodes, the current node is checked against the list of ignored node types before throwing the
NotEncodableValueExceptionif it's a document type node.