[PropertyInfo] PhpStan extractor nested object fix #44637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmikalkenas
force-pushed
the
phpstan-extractor-fix
branch
from
640a9ac to
fcecfe1
Compare
rmikalkenas
force-pushed
the
phpstan-extractor-fix
branch
from
fcecfe1 to
1b11e78
Compare
|
Hey! I think @Korbeil has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Just some cs issues and GTM
| } | ||
|
|
||
| private function extractFromFullClassName(string $fullClassName): array | ||
| private function collectUses(\ReflectionClass $reflection): array |
Member
There was a problem hiding this comment.
collectTraits would be a better name IMHO
Contributor
Author
There was a problem hiding this comment.
I think collectUses sounds more logic in this context, because method collects not only traits, but class uses as well
Contributor
Author
There was a problem hiding this comment.
@nicolas-grekas rebased the branch, waiting for yours input on remaining issue
src/Symfony/Component/PropertyInfo/PhpStan/NameScopeFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PhpStan/NameScopeFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PhpStan/NameScopeFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PhpStan/NameScopeFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php
Outdated
Show resolved
Hide resolved
Korbeil
approved these changes
Dec 16, 2021
Contributor
Korbeil
left a comment
Korbeil
left a comment
There was a problem hiding this comment.
Apart from Nicolas CS fixes it looks good to me too 👍
rmikalkenas
force-pushed
the
phpstan-extractor-fix
branch
from
1b11e78 to
2544689
Compare
rmikalkenas
force-pushed
the
phpstan-extractor-fix
branch
from
2544689 to
78d51de
Compare
nicolas-grekas
approved these changes
Dec 26, 2021
Member
|
Thank you @rmikalkenas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpStanExtractor wrongly extracts object type when it is in a different namespace