Skip to content

[DoctrineBridge][Form] Fix EntityType memory leak #44497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbond wants to merge 1 commit into from
Closed

[DoctrineBridge][Form] Fix EntityType memory leak #44497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
use Symfony\Component\Dotenv\Dotenv;
use Symfony\Component\ErrorHandler\ErrorHandler;
use Symfony\Component\EventDispatcher\DependencyInjection\RegisterListenersPass;
use Symfony\Component\Form\ChoiceList\Factory\Cache\AbstractStaticOption;
use Symfony\Component\Form\DependencyInjection\FormPass;
use Symfony\Component\HttpClient\DependencyInjection\HttpClientPass;
use Symfony\Component\HttpFoundation\Request;
Expand Down Expand Up @@ -97,6 +98,15 @@ public function boot()
}
}

public function shutdown()
Copy link
Member Author

@kbond kbond Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue but I don't expect this is the proper solution. I'd like some input on where this fix should be made.

{
parent::shutdown();

if (class_exists(AbstractStaticOption::class)) {
AbstractStaticOption::reset();
Copy link
Member

@nicolas-grekas nicolas-grekas Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would adding this call to DoctrineType::reset() fix the leak for you?

Copy link
Member Author

@kbond kbond Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that didn't work.

}
}

public function build(ContainerBuilder $container)
{
parent::build($container);
Expand Down