Skip to content

Conversation

@Sacrome
Copy link

@Sacrome Sacrome commented Nov 16, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

This PR ensures hostnames without a TLD that contain hyphens and/or underscores are considered valid by the UrlValidator Constraint.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@rpkamp
Copy link
Contributor

rpkamp commented Nov 16, 2021

Failures seem unrelated and happen in other PRs as well (eg #44085)

@welcoMattic
Copy link
Member

Thank you for your contribution, I think this PR is fixing the same thing as #43876

@Sacrome Sacrome closed this Nov 22, 2021
@Sacrome Sacrome deleted the 5.3 branch November 22, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants